Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#148 load by bound #160

Merged
merged 4 commits into from
Dec 22, 2021
Merged

Conversation

robstoll
Copy link
Contributor

the /fountains endpoint now requires sw and ne query parameter instead of city

moreover:

  • fetch processing errors by bound
  • require a location for byId so that we can look it up in cache
  • fix TestCityBounds (TestCity BoundingBox has illegal specification #157)
  • failure handling for cache populati
  • send 404 in case json object is undefined (and not only log error
      and send undefined)
  • catch errors and send to next middleware (uncaugth exception causes no response #155)
  • removed database.service.ts
  • increased REQUEST_LIMIT to 10MB as we query more fountains now
  • updated Api.yaml accordingly
  • updated express from 4.17.1 to 4.17.2
  • update node-cache from 4.2.1 to 5.1.2

cleanup:

  • use BoundingBox instead of separate minLng, minLat... as parameter
  • added last_scan to FountainCollection and provide a factory function
      which set it automatically to new Date()
  • fix binding in router.ts

the /fountains endpoint now requires sw and ne query parameter instead of city

moreover:
- require a location for byId so that we can look it up in cache
- fix TestCityBounds (water-fountains#157)
- failure handling for cache populati
- send 404 in case json object is undefined (and not only log error
  and send undefined)
- catch errors and send to next middleware (water-fountains#155)
- removed database.service.ts
- increased REQUEST_LIMIT to 10MB as we query more fountains now
- updated Api.yaml accordingly
- updated express from 4.17.1 to 4.17.2
- update node-cache from 4.2.1 to 5.1.2

cleanup:
- use BoundingBox instead of separate minLng, minLat... as parameter
- added last_scan to FountainCollection and provide a factory function
  which set it automatically to new Date()
- fix binding in router.ts
also, re-added the fill-artist etc. logic for byId
@robstoll robstoll merged commit d55010b into water-fountains:develop Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant