This repository has been archived by the owner on May 6, 2020. It is now read-only.
Add nov-search-forward and nov-search-backwards #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freesteph
force-pushed
the
feature/search
branch
from
3e9fc52 to
a3c2ced
Compare
|
Sorry, but no. First of all, the code doesn't fit into the rest of the codebase, second, if anything I'd prefer an isearch-based solution using |
|
Fair enough. I would have appreciated some feedback on that Reddit post if you knew all the way you were going to close this PR immediately, it would have saved us both the trouble. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Thanks for
nov-mode. As you've seen on the Emacs Reddit, this is potentially my first Elisp contribution so do provide guidance!It adds
nov-search-forwardandnov-search-backward, both composed on a genericnov--search-directionthat decides how it should move between pages and how it should search for the query based on the value of its direction parameter. I don't know if that's very lispy at all but thought I'd re-use the logic.