Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset counters for each loop #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

reset counters for each loop #2

wants to merge 1 commit into from

Conversation

ragho
Copy link

@ragho ragho commented Nov 9, 2017

  • Reset upload_count, download_count and delete_count before each loop. Loops now return consistent values
  • Add a soft fail to createBucket (assume previously created) to be consistent with the pre-packaged binary (s3-benchmark.ubuntu binary does not attempt to create a bucket)

razorsedge
razorsedge reviewed Feb 1, 2018
View reviewed changes
s3-benchmark.go
// reset counters
upload_count = 0
download_count = 0
delete_count = 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why successive loops were always faster than the previous loop...

@razorsedge
Copy link

Works for me. Ship it!

@razorsedge
Copy link

@jcflowers This PR is pretty much required in order to have accurate results on multiple loops.

@zmedico
Copy link

zmedico commented Apr 18, 2019

Fixed in 200c625 from #5.

@razorsedge razorsedge mentioned this pull request Apr 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razorsedge razorsedge razorsedge left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ragho @razorsedge @zmedico