feat(enhancement): Add a "quiet" personality that prevents passive ha…

…ils but still allows direct hails (endless-sky#9857)

By contrast, mute blocks all hails with a ship.

source/Personality.cpp

@@ -64,6 +64,7 @@ namespace {
 		UNRESTRICTED,
 		RESTRICTED,
 		DECLOAKED,
+		QUIET,
 
 		// This must be last so it can be used for bounds checking.
 		LAST_ITEM_IN_PERSONALITY_TRAIT_ENUM
@@ -105,7 +106,8 @@ namespace {
 		{"ramming", RAMMING},
 		{"unrestricted", UNRESTRICTED},
 		{"restricted", RESTRICTED},
-		{"decloaked", DECLOAKED}
+		{"decloaked", DECLOAKED},
+		{"quiet", QUIET}
 	};
 
 	// Tokens that combine two or more flags.
@@ -434,6 +436,13 @@ bool Personality::IsDecloaked() const
 
 
 
+bool Personality::IsQuiet() const
+{
+	return flags.test(QUIET);
+}
+
+
+
 const Point &Personality::Confusion() const
 {
 	return confusion;

source/Personality.h

@@ -84,6 +84,7 @@ class Personality {
 	bool IsMarked() const;
 	bool IsMute() const;
 	bool IsDecloaked() const;
+	bool IsQuiet() const;
 
 	// Current inaccuracy in this ship's targeting:
 	const Point &Confusion() const;
@@ -101,7 +102,7 @@ class Personality {
 private:
 	// Make sure this matches the number of items in PersonalityTrait,
 	// or the build will fail.
-	static const int PERSONALITY_COUNT = 36;
+	static const int PERSONALITY_COUNT = 37;
 
 	bool isDefined = false;
 

source/Ship.cpp

@@ -1519,7 +1519,7 @@ bool Ship::CanSendHail(const PlayerInfo &player, bool allowUntranslated) const
 		return false;
 
 	// Make sure this ship is able to send a hail.
-	if(!Crew() || Cloaking() >= 1. || GetPersonality().IsMute())
+	if(!Crew() || Cloaking() >= 1. || GetPersonality().IsMute() || GetPersonality().IsQuiet())
 		return false;
 
 	// Ships that don't share a language with the player shouldn't communicate when hailed directly.