N-API CMake.js build #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not had chance to try this but this sounds awesome :) - currently experimenting with edits to the the binding.gyp and this might make that easier. |
clach04
pushed a commit
to clach04/node-odbc__DO_NOT_USE
that referenced
this pull request
Dec 17, 2020
Create an issue template for reporting bugs Signed-off-by: Mark Irish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake.js is a Node.js native addon build tool which works exactly like node-gyp, but instead of gyp, it is based on CMake build system. With this we don't need Python anymore (node-gyp on windows still dependent on Python 2.x). There is no change have done to the default node-gyp build, the CMake build is an addon. Once we got enough confidence with the CMake build then we could remove the node-gyp build facility in future.
https://github.com/cmake-js/cmake-js