chore(weave): Extract common functions in eval.py into re-usable common modules.
#3328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=13ca03d598a05b1c2579cd966fc78d061047c517 |
tssweeney
changed the title
eval.py into re-usable common modules.
andrewtruong
reviewed
Jan 6, 2025
| @@ -57,3 +68,110 @@ def get_infer_method(model: Model) -> Op: | |||
| raise MissingInferenceMethodError( | |||
| f"Missing a method with name in ({INFER_METHOD_NAMES})" | |||
| ) | |||
|
|
|||
|
|
|||
| # Using `dataclass` because pydantic does not like `Call` as a property | |||
There was a problem hiding this comment.
it doesn't like the future
andrewtruong
reviewed
Jan 6, 2025
| score_call: Call | ||
|
|
||
|
|
||
| ApplyScorerResult = ApplyScorerSuccess |
There was a problem hiding this comment.
There's no error case?
tssweeney
merged commit db9f4da
into
tim/extract_scoring_mechanics_into_module
120 of 122 checks passed
tssweeney
deleted the
tim/extract_scoring_mechanics_into_module_new_files
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another refactor PR to decouple Scoring and model prediction mechanics from the eval api itself. This builds off of #3325. There should be no functional changes to the user. Specifically:
weave/trace/op_caller.pynow contains the helper functions forasync_callandasync_call_opwhich unifies op calling for async and sync calls under the same API.apply_scorer_asyncintoweave/scorers/base_scorer.pyprepping for re-use elsewhereapply_model_asyncintoweave/flow/model.pyfor similar reasons.