Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(weave): Add import time benchmarking script #3234

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

andrewtruong
Copy link
Collaborator

@andrewtruong andrewtruong commented Dec 13, 2024

This PR adds a benchmarking script and a test to make sure import times don't exceed 3s. As of writing, the import time is ~1.3s on an M1 MBP

@circle-job-mirror
Copy link

@andrewtruong andrewtruong marked this pull request as ready for review December 16, 2024 18:12
@andrewtruong andrewtruong requested a review from a team as a code owner December 16, 2024 18:12
Copy link
Contributor

@bcsherma bcsherma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

import_time = run_single_import()

# Ideally the import takes < 1s, but in CI it can take up to 3s.
assert import_time < 3, f"Import time was {import_time} seconds"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make configurable? also pr description says 2s

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated description

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@andrewtruong andrewtruong merged commit 6d95ebb into master Dec 16, 2024
120 checks passed
@andrewtruong andrewtruong deleted the andrew/benchmark branch December 16, 2024 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants