-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(docs): Disable GH checks on docs
that don't apply to docs
#3206
base: master
Are you sure you want to change the base?
Conversation
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=5cf60727fcfb920c3ab0bf6ddece87466211d014 |
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA Weave Build Bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Description
https://wandb.atlassian.net/browse/DOCS-1108
Proposes disabling GH action checks that don't apply to things that live in the
docs
folder.Reason:
Testing
docs
to test what happens on this branchweave/.github/workflows/check-which-tests-to-run.yaml
weave/.github/workflows/cla.yaml
weave/.github/workflows/deploy.yaml
weave/.github/workflows/pr.yaml
weave/.github/workflows/release.yaml
trace-docs
inweave/.github/workflows/test.yaml
I added this to
trace-docs
to override the global docs disable on this test:if: ${{ github.event_name == 'push' && (github.event.before == 'docs/**' || github.event.commits | contains('docs')) }}
. Alternatively, could break out into separate file, but need to check with team if this would cause other issues / more workHelp requested from @wandb/weave-team before proceeding further
#3206 (comment)