Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: entrypoints and transactions card static ui #26

Merged
merged 16 commits into from
Jun 7, 2024
Merged

feat: entrypoints and transactions card static ui #26

merged 16 commits into from
Jun 7, 2024

Conversation

bhavyagosai
Copy link
Contributor

@bhavyagosai bhavyagosai commented May 30, 2024 •
edited
Loading

  • resolves Data tile FE: Entrypoints and Transactions #11
  • added packages and components:
    • dayjs
    • shadcn components:
      • tooltip
      • label
      • input
      • select
      • table
      • skeleton
  • added extended components for better code + features + reusability
    • common-tooltip
      • added hideOnClick boolean prop
    • common-select
      • set a max height for the select dropdown
    • input-extended
      • added adornment support
  • added static data
  • added custom scrollbar
  • added loaders wherever needed
  • added tooltips to data wherever deemed necessary
  • added copy support to transaction hashes
  • cycling through 10 static colors in stacked bar chart

Note:

  • static height added in order to let data cap at specific length and scroll
  • scrollbar in scrollable components is always visible for better ux
  • card heading changed according to ui (non uniform now)

@bhavyagosai
add: packages + ui components
aedd2fe
@bhavyagosai
add: extended ui components
8ffd0a7
@bhavyagosai
add: helper functions
fe7cf91
@bhavyagosai
feat: add entrypoints + transactions ui
4fe3aea 
- added static data
- added custom scrollbar which is always visible for better ux
- added loaders wherever needed
- added tooltips to data wherever deemed necessary
- added copy support to transaction hashes
- cycling through 10 static colors so that they never repeat adjacently + can be reused
@bhavyagosai
fix: improved util function
8cbfa95
@barabanovro barabanovro requested a review from melnikga May 31, 2024 09:08
melnikga
melnikga suggested changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@melnikga melnikga left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, please make the following changes:

  1. Fix lint errors
    ![image](https://github.com/walnuthq/starkflare/assets/91109124/bb6443a7-c2f2-481c-8944-63e360377d28

  2. Move the entrypoints-stacked-bar-chart file to the components/stats/entryponits folder

  3. I also think it's worth aligning the tables.
    image

  4. I noticed that you import the Input component from shadcn, but don't use it. Instead, you create your own using the standard html tag "input". It is necessary to use the Input component from shadcn

@bhavyagosai bhavyagosai requested a review from melnikga June 2, 2024 22:45
melnikga
melnikga approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@melnikga melnikga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melnikga
Copy link
Collaborator

melnikga commented Jun 3, 2024 •
edited
Loading

@bhavyagosai resolve branch conflicts please

@bhavyagosai bhavyagosai requested a review from melnikga June 3, 2024 22:44
@bhavyagosai
Copy link
Contributor Author

resolved!

melnikga
melnikga suggested changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@melnikga melnikga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhavyagosai can you please fix the merge conflicts again?

@barabanovro barabanovro self-requested a review June 7, 2024 07:44
@barabanovro barabanovro merged commit f69c030 into walnuthq:main Jun 7, 2024
@bhavyagosai bhavyagosai mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melnikga melnikga melnikga requested changes

@barabanovro barabanovro barabanovro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data tile FE: Entrypoints and Transactions
3 participants
@bhavyagosai @melnikga @barabanovro