Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect usage of MCQJudge.judge() in README.md and docs/quickst… #116

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

fanndu
Copy link
Contributor

@fanndu fanndu commented Oct 10, 2024

Description

This PR fixes the incorrect usage of the MCQJudge.judge() method in two code examples:

  1. README.md
  2. docs/quickstart/mcq.md

Previously, the method was called with only one argument, which caused the score to always return false due to the missing second argument (the correct answer). This PR updates both examples to pass the required second argument, ensuring correct functionality.

Changes

  • Updated README.md example to include the correct call to MCQJudge.judge(answer, correct_answer)
  • Updated docs/quickstart/mcq.md with the same fix.

Testing

Verified the correctness of the method call and confirmed that the score is calculated properly when both arguments are passed.

Related Issue

Fixes #114

…art/mcq.md by adding missing second argument
Copy link

codesandbox bot commented Oct 10, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@ThePyProgrammer
Copy link
Member

Noted regarding the change, thank you for pointing out this mistake! I will merge this PR, thank you for the assistance 🙂

@ThePyProgrammer ThePyProgrammer merged commit 519d602 into walledai:main Oct 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect usage of MCQJudge.judge() in README.md and docs/quickstart/mcq.md - missing anwser argument
2 participants