Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some posters offsetting opposite as they should #313

Open
MrMelbert opened this issue Aug 7, 2024 · 4 comments
Open

Some posters offsetting opposite as they should #313

MrMelbert opened this issue Aug 7, 2024 · 4 comments

Comments

@MrMelbert
Copy link

This is a poster, using the north helper

image

Same poster in SDMM

image


Other posters seem to work fine.

image

@MrMelbert
Copy link
Author

Two posters, same helper, one is broken one is not

image

@unit0016
Copy link

unit0016 commented Aug 7, 2024

Had this happen with calendars too. My hunch is race condition; somehow.

LemonInTheDark pushed a commit that referenced this issue Aug 12, 2024
… mapping objects (#325)

This attempts to fix the various issues with sinks, APCs, and various other wallmounts in-game that are running into mapping issues.

I've got APCs working properly from their own subtype of the macro, but at the second I'm still breaking down where things are falling apart on the other subtypes to get those fixed.

Taking #285 up alongside #248 and #313 as part of a wallmount combined fix atm, there's a few causes for this but it seems to primarily be a combination of wall-mounted objects using the older system of offsets and directions, some things have additional offsets in initialize, and misuse of the existing wallmount macros combined with MAP_SWITCH() causing some things to appear the opposite of how they should in-game.

At this current point, this will not fix everything, but will be a substantial improvement to much of it
@LemonInTheDark
Copy link
Member

this still an issue?

@unit0016
Copy link

Doesn't look like it?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants