Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many objects with offsets (bar sign, clock, buttons, etc.) do not show properly in map editors #285

Open
TheVekter opened this issue Aug 3, 2024 · 4 comments

Comments

@TheVekter
Copy link

TheVekter commented Aug 3, 2024

This is probably an issue with StrongDMM not properly handling pixel_z yet but it could be any number of things and is happening with things that don't even have a pixel_z value in their vars.

It results in things like this:

Editor:
image

In-game:
image

Jacq asked me to make a list of what I've found so far.

Things I know are doing this:

  • Pretty much every button
  • Directional department signs
  • The bar sign (kind of)
  • Clocks (kind of)

Things I theorize might also do this but I haven't found examples of yet:

  • Some APCs
  • Signs (I've seen a few on the wrong layer but I think those are south-facing)
  • Lights (Some lights are just kind of fucked up in general and appearing directly in the middle of other objects, I don't think this is related but it could be)

I say "kind of" because the directional helper versions of the bar sign and clocks work fine, you just have to place them on the wall itself instead of next to it like we used to.

@TheVekter
Copy link
Author

We did some pondering in Discord about this and it might have something to do with the wallmounted component applying extra offsets. I might just need to adjust those.

@ArcaneMusic
Copy link

Again for record: The issue is with /datum/element/wall_mount
Which is different from /datum/component/wall_mounted

@TheVekter
Copy link
Author

Yes, thank you. I'll do some testing here in a bit.

@loganuk
Copy link

loganuk commented Aug 6, 2024

Another comment on bar signs which is linked to this - tgstation#85641

LemonInTheDark pushed a commit that referenced this issue Aug 12, 2024
… mapping objects (#325)

This attempts to fix the various issues with sinks, APCs, and various other wallmounts in-game that are running into mapping issues.

I've got APCs working properly from their own subtype of the macro, but at the second I'm still breaking down where things are falling apart on the other subtypes to get those fixed.

Taking #285 up alongside #248 and #313 as part of a wallmount combined fix atm, there's a few causes for this but it seems to primarily be a combination of wall-mounted objects using the older system of offsets and directions, some things have additional offsets in initialize, and misuse of the existing wallmount macros combined with MAP_SWITCH() causing some things to appear the opposite of how they should in-game.

At this current point, this will not fix everything, but will be a substantial improvement to much of it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants