🐛 fix: RANK 값 안넘어가는 문제 수정

waktaplay · Sep 26, 2024 · 6204adb · 6204adb
1 parent e967b72
commit 6204adb
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 15 deletions.
diff --git a/src/charts/charts.service.ts b/src/charts/charts.service.ts
@@ -44,7 +44,7 @@ export class ChartsService {
 
             return {
               ...music,
-              rank: chart?.[type] || { views: 0, rank: 'NEW' },
+              rank: chart?.[type] || { views: 0, rank: -1 },
             };
           })
           .sort((a, b) => b.rank.views - a.rank.views),

diff --git a/src/charts/dto/chart.dto.ts b/src/charts/dto/chart.dto.ts
@@ -21,10 +21,10 @@ class ChartData extends musicDetailDto {
     views: number;
 
     /**
-     * 조회수 증감량
-     * @example NEW
+     * 조회수 증감량 (-1: NEW)
+     * @example -1
      */
-    rank: number | 'NEW';
+    rank: number;
   };
 }
 

diff --git a/src/common/repository/schemas/statistics.schema.ts b/src/common/repository/schemas/statistics.schema.ts
@@ -9,8 +9,17 @@ export interface IStatistics {
 }
 
 export type IStatisticData = {
+  /**
+   * 현재 조회수 값
+   * @example 1
+   */
   views: number;
-  rank: number | 'NEW';
+
+  /**
+   * 조회수 증감량
+   * @example -1
+   */
+  rank: number;
 };
 
 export const StatisticsSchema = new mongoose.Schema<IStatistics>({
@@ -26,9 +35,9 @@ export const StatisticsSchema = new mongoose.Schema<IStatistics>({
       default: 0,
     },
     rank: {
-      type: Number || String,
+      type: Number,
       required: true,
-      default: 'NEW',
+      default: -1,
     },
   },
   daily: {
@@ -38,9 +47,9 @@ export const StatisticsSchema = new mongoose.Schema<IStatistics>({
       default: 0,
     },
     rank: {
-      type: Number || String,
+      type: Number,
       required: true,
-      default: 'NEW',
+      default: -1,
     },
   },
   total: {
@@ -50,9 +59,9 @@ export const StatisticsSchema = new mongoose.Schema<IStatistics>({
       default: 0,
     },
     rank: {
-      type: Number || String,
+      type: Number,
       required: true,
-      default: 'NEW',
+      default: -1,
     },
   },
   weekly: {
@@ -62,9 +71,9 @@ export const StatisticsSchema = new mongoose.Schema<IStatistics>({
       default: 0,
     },
     rank: {
-      type: Number || String,
+      type: Number,
       required: true,
-      default: 'NEW',
+      default: -1,
     },
   },
 });
diff --git a/src/songs/dto/music.dto.ts b/src/songs/dto/music.dto.ts
@@ -91,8 +91,17 @@ export class musicDetailDto extends musicDto {
 
 export interface IMusicChart extends musicDetailDto {
   rank: {
-    current: number;
-    increase: number | string;
+    /**
+     * 현재 조회수 값
+     * @example 1
+     */
+    views: number;
+
+    /**
+     * 조회수 증감량
+     * @example -1
+     */
+    rank: number;
   };
 }