More human-friendly WAGTAIL_SITE_NAME #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laymonage
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
It slightly irks me when we call this "(The) Wagtail Bakery" (without the "demo"), since we also have https://github.com/wagtail-nest/wagtail-bakery (which is older than the demo).
I know this is the name we use in the front-facing site's header though, so I suppose it's just my pet peeve 😂
|
@laymonage IIRC, it was originally my suggestion to give it the developer-facing name "bakerydemo" to avoid that naming collision. I think it's fair game to call it "The Wagtail Bakery" in user-facing text within the demo itself though - think of it as roleplaying in a fictional universe where the Icelandic bakery exists but the package doesn't :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Wagtail 6.3
WAGTAIL_SITE_NAMEis used as the heading for the admin dashboard, so let's make it a human-friendly title (and avoid creating the temptation for developers to try and munge the capitalisation in code, as we did in #12592 :-) )