Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 20 & Upgrade npm packages (#463) Fix #462 #463

Merged
merged 1 commit into from
Dec 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{
"extends": [
"eslint:recommended"
],
"extends": ["eslint:recommended"],
"parserOptions": {
"ecmaVersion": 9
"ecmaVersion": 2020
},
"env": {
"browser": true
Expand All @@ -13,9 +11,7 @@
"lines-between-class-members": [
"error",
"always",
{
"exceptAfterSingleLine": true
}
{ "exceptAfterSingleLine": true }
],
// note you must disable the base rule as it can report incorrect errors
"no-use-before-define": "off",
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ jobs:
steps:
- uses: actions/checkout@v3
- name: Set up Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16
node-version-file: '.nvmrc'
cache: 'npm'
- name: Install dependencies
run: npm ci
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20
11 changes: 5 additions & 6 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,25 +27,24 @@ repos:
hooks:
- id: djhtml
- repo: https://github.com/pre-commit/mirrors-prettier
rev: v2.5.1
rev: v3.1.0
hooks:
- id: prettier
types_or: [css, javascript, json, yaml]
- repo: https://github.com/pre-commit/mirrors-eslint
rev: v8.8.0
rev: v8.55.0
hooks:
- id: eslint
types: [file]
files: \.(js)$
args: [--report-unused-disable-directives]
additional_dependencies:
- eslint@8.8.0
- eslint@8.55.0
- repo: https://github.com/thibaudcolas/pre-commit-stylelint
rev: v14.2.0
hooks:
- id: stylelint
files: \.css$
additional_dependencies:
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
7 changes: 6 additions & 1 deletion .stylelintrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
{
"extends": ["stylelint-config-standard", "stylelint-config-prettier"],
"extends": ["stylelint-config-standard"],
"rules": {
"declaration-block-no-redundant-longhand-properties": [
true,
{ "ignoreShorthands": ["gap", "inset"] }
],
"no-descending-specificity": null,
"media-feature-range-notation": null,
"custom-property-pattern": "^([a-z][a-z0-9]*)(-{1,2}[a-z0-9]+)*$",
"selector-class-pattern": [
"^[a-z]+[0-9]{0,2}(-[a-z0-9]+)*(__[a-z0-9]+(-[a-z0-9]+)*)?(--[a-z0-9]+(-[a-z0-9]+)*)?$",
Expand Down
4 changes: 3 additions & 1 deletion bakerydemo/static/css/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -1414,7 +1414,9 @@ input[type='radio'] {
padding: 15px 25px;
display: inline-block;
vertical-align: middle;
transition: color ease 0.1s, background-color ease 0.1s;
transition:
color ease 0.1s,
background-color ease 0.1s;
}

.homepage .home-hero .hero-cta-link:hover {
Expand Down
Loading