-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Generic and Site settings models. Fix #395 #419
Add Generic and Site settings models. Fix #395 #419
Conversation
@@ -1444,6 +1365,13 @@ | |||
"workflow": 1 | |||
} | |||
}, | |||
{ | |||
"model": "wagtailcore.workflowcontenttype", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell this is a new model from a minor wagtail release that just hasn't been included until now
@@ -3587,6 +3515,22 @@ | |||
"file_hash": "" | |||
} | |||
}, | |||
{ | |||
"model": "wagtailusers.userprofile", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this was added, doesn't seem to break anything but can't figure out how I managed to add it in either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that for some reason we didn’t have a Wagtail user profile instance in the fixtures until now. Perhaps this gets created only when accessed the first time – which we now do on every page as part of determining which theme to show the UI in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking great @Morsey187! The fixtures changes surprise me a bit but yeah we don’t update the fixtures that often so I’ll probs just split the unrelated changes to a different commit and move on.
4c5571c
to
d9e8ab3
Compare
Thanks @Morsey187 and @thibaudcolas - this is a really helpful addition |
Resolves issue: 395
Adds:
SiteSettings
extending from Wagtail'sBaseSiteSetting
classtitle_suffix
which is used to replace static text in the base.html'stitle_suffix
blockGenericSettings
extending from Wagtail'sBaseGenericSetting
classgithub_url
,twitter_url
,organisation_url
which are now used to conditionally display the footer icons and populate their href attributes.bakerydemo.json
i.e.load_initial_data