Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

강의계획서 프록시 안한 url 제공 #292

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

asp345
Copy link
Member

@asp345 asp345 commented Oct 24, 2024

https://wafflestudio.slack.com/archives/C0PAVPS5T/p1729768106297699?thread_ts=1728361353.404059&cid=C0PAVPS5T
앱에서 referer 헤더 적용이 가능한 경우 proxy를 쓰지 않도록 url을 2개 보내주는게 좋겠다고 하네요
prefix는 바뀔일 없어서 그냥 상수로 처리했습니다

@asp345 asp345 requested review from PFCJeong and a team as code owners October 24, 2024 11:25
@asp345 asp345 requested review from davin111, Hank-Choi and SeonghaeJo and removed request for a team October 24, 2024 11:25
Copy link
Contributor

@Hank-Choi Hank-Choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뭔가 기존 url은 raw가 아니면 뭐지? 싶을 수 있으니

data class CoursebookOfficialResponse(
    val rawUrl: String,
    val proxyUrl: String? = null,
    val url: String = proxyUrl ?: rawUrl,
)

이렇게 바꾸는건 어떨까요
url은 구버전 대응용으로 두고요

@Hank-Choi
Copy link
Contributor

레거시를 더 쌓는 느낌이기도 해서 의견주세요

@SeonghaeJo
Copy link
Contributor

SeonghaeJo commented Oct 28, 2024

의미 전달은 한결님 의견이 좋은 것 같습니다.
다만 필드를 2개 추가하는 것이 좀 걸린다면, 찬영님이 원래 제안했던 rawUrl에서 변수명만 unproxiedUrl이나 noProxyUrl로 바꾸면 프록시를 사용하지 않는다는 의미를 더 잘 전달할 수 있지 않을까 싶네요.
(그냥 가볍게 참고만 해주세요)

@asp345
Copy link
Member Author

asp345 commented Oct 29, 2024

제 생각에도 두 경우 다 명시를 하는게 좋을것 같아요
의견 반영해서 수정했습니다

@asp345 asp345 changed the title 강의계획서 rawUrl 필드 제공 강의계획서 프록시 안한 url 제공 Oct 29, 2024
@asp345 asp345 merged commit 59122ce into develop Oct 29, 2024
2 checks passed
@asp345 asp345 deleted the feature/no-proxy-url branch October 29, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants