Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flushDatabase에서 일부 prefix 제외하고 삭제 #287

Closed
wants to merge 1 commit into from
Closed

flushDatabase에서 일부 prefix 제외하고 삭제 #287

wants to merge 1 commit into from

Conversation

asp345
Copy link
Member

@asp345 asp345 commented Oct 12, 2024

#286 (comment) 이 문제 해결하려고 합니다

@asp345 asp345 requested review from PFCJeong and a team as code owners October 12, 2024 09:57
@asp345 asp345 requested review from davin111, Hank-Choi and SeonghaeJo and removed request for a team October 12, 2024 09:57
Hank-Choi
Hank-Choi reviewed Oct 12, 2024
View reviewed changes
Copy link
Contributor

@Hank-Choi Hank-Choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 범용적으로 redis를 쓰는거라 flushDatabase를 사실 쓰면 안되는데요
아주 이전에는 모두 배치잡 관련된 데이터만 저장해놔서 편의상 쓰던 느낌이었어요

이 PR에서 Cache에 서비스 관련 스펙이 들어가는 것도 이상하고
지금은 배치에서 지워야할 데이터가 없어서 그냥 삭제하는 게 좋을 것 같아요

제가 PR 하나 올릴게요

@asp345 asp345 closed this Oct 12, 2024
@asp345 asp345 deleted the fix/redis-flush branch October 12, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hank-Choi Hank-Choi Hank-Choi left review comments

@PFCJeong PFCJeong Awaiting requested review from PFCJeong PFCJeong is a code owner

@davin111 davin111 Awaiting requested review from davin111 davin111 is a code owner automatically assigned from wafflestudio/snutt-server

@SeonghaeJo SeonghaeJo Awaiting requested review from SeonghaeJo SeonghaeJo is a code owner automatically assigned from wafflestudio/snutt-server

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asp345 @Hank-Choi