Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

소셜로그인 provider 관련 코드 수정 #295

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

Hank-Choi
Copy link
Contributor

@Hank-Choi Hank-Choi commented Nov 6, 2024

변경사항

  • url에 언더바 제거
  • local 이 포함되어있는데 socialProvider라는 이름이 거슬려서 변경
  • 인증 제공자 list로 반환
  • 에러 detail 없애고 이메일 중복 에러 displayMessage 보충
  • enum을 이용한 when 내 else 제거
  • 로그인 수단 아예 없어지는 것 방지
  • filed.write.always 삭제 - 보기도 힘들고 용량도 차지

#246 #250 리뷰를 안해서 고치고 싶은 것들 그냥 제가 반영함
리뷰 없이 머지하는거 지양 부탁

@Hank-Choi Hank-Choi requested review from PFCJeong and a team as code owners November 6, 2024 15:42
@Hank-Choi Hank-Choi requested review from asp345, davin111 and SeonghaeJo and removed request for a team November 6, 2024 15:42
@Hank-Choi Hank-Choi force-pushed the feature/get-auth-provider branch from f79c887 to ad5e299 Compare November 6, 2024 15:46
@Hank-Choi Hank-Choi requested a review from SeonghaeJo November 6, 2024 16:32
@Hank-Choi Hank-Choi force-pushed the feature/get-auth-provider branch from d2a003e to f7bccc1 Compare November 6, 2024 16:35
@Hank-Choi Hank-Choi merged commit 3e765c8 into develop Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants