Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #262. Fixes #458. #461

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Revert #262. Fixes #458. #461

merged 1 commit into from
Dec 6, 2023

Conversation

hober
Copy link
Contributor

@hober hober commented Dec 5, 2023

@hober hober requested review from cynthia and torgo December 5, 2023 17:41
@hober hober self-assigned this Dec 5, 2023
@hober hober mentioned this pull request Dec 5, 2023
@hober hober linked an issue Dec 5, 2023 that may be closed by this pull request
@LeaVerou
Copy link
Member

LeaVerou commented Dec 5, 2023

There was nothing from that section that we'd want to incorporate in the existing section?

@hober
Copy link
Contributor Author

hober commented Dec 5, 2023

There was nothing from that section that we'd want to incorporate in the existing section?

it was literally an earlier version of the text that @cynthia merged later on, so no.

Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then

@cynthia cynthia merged commit 1eadb6d into main Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate section?
3 participants