Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing algorithm length property in HMAC key generation #394

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

twiss
Copy link
Member

@twiss twiss commented Dec 31, 2024

Fixes #392.


Preview | Diff

@twiss twiss requested a review from devgianlu December 31, 2024 14:22
@twiss twiss merged commit ff33c55 into main Dec 31, 2024
2 checks passed
@twiss twiss deleted the hmac-generate-algorithm-length branch December 31, 2024 15:49
github-actions bot added a commit that referenced this pull request Dec 31, 2024
SHA: ff33c55
Reason: push, by twiss

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
devgianlu added a commit to devgianlu/ladybird that referenced this pull request Dec 31, 2024
This assignment was missing from the spec, but has been fixed since
w3c/webcrypto#394.
devgianlu added a commit to devgianlu/ladybird that referenced this pull request Dec 31, 2024
This assignment was missing from the spec, but has been fixed since
w3c/webcrypto#394.
devgianlu added a commit to devgianlu/ladybird that referenced this pull request Dec 31, 2024
This assignment was missing from the spec, but has been fixed since
w3c/webcrypto#394.
devgianlu added a commit to devgianlu/ladybird that referenced this pull request Dec 31, 2024
This assignment was missing from the spec, but has been fixed since
w3c/webcrypto#394.
devgianlu added a commit to devgianlu/ladybird that referenced this pull request Dec 31, 2024
This assignment was missing from the spec, but has been fixed since
w3c/webcrypto#394.

Also add relevant WPT tests.
devgianlu added a commit to devgianlu/ladybird that referenced this pull request Dec 31, 2024
This assignment was missing from the spec, but has been fixed since
w3c/webcrypto#394.

Also add relevant WPT tests.
awesomekling pushed a commit to LadybirdBrowser/ladybird that referenced this pull request Jan 2, 2025
This assignment was missing from the spec, but has been fixed since
w3c/webcrypto#394.

Also add relevant WPT tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly missing step in HMAC key generation operation
2 participants