Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VideoEncoderConfig.contentHint #729

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Add VideoEncoderConfig.contentHint #729

merged 2 commits into from
Oct 26, 2023

Conversation

Djuffin
Copy link
Contributor

@Djuffin Djuffin commented Oct 17, 2023 •
edited by pr-preview bot
Loading

A way to indicate type of content VideoEncoder should expect to see in coming frames.

Resolve #478

Preview | Diff

aboba
aboba reviewed Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@aboba aboba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest that you note that content hints do not override other configuration settings. Also, content hint implications for rate control are the responsibility of the application, not WebCodecs.

@Djuffin
Copy link
Contributor Author

Djuffin commented Oct 17, 2023 •
edited
Loading

I added a note that content hint is overridden by any codec specific options like the one we have for AV1.
I don't think there is any vagueness regarding rate control.

dalecurtis
dalecurtis reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@dalecurtis dalecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defer to editors for approval, but lgtm

@Djuffin
Copy link
Contributor Author

Djuffin commented Oct 20, 2023 •
edited
Loading

@padenot Paul, could you take a look?

@aboba aboba merged commit 11307bc into w3c:main Oct 26, 2023
16 checks passed
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
292f9e5 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
5792e8a 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
a7f2e44 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
f436170 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
a6a6ede 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
a728941 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
78c35e5 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
726084b 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
2a4dcd5 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
f2d6628 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
538d976 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
0bd5e68 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
438c02d 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
3add37b 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
ab49dac 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Oct 26, 2023
@aboba @github-actions
Merge pull request #729 from Djuffin/content-hint
2fe6b1d 
SHA: 11307bc
Reason: push, by aboba

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@padenot padenot mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalecurtis dalecurtis dalecurtis left review comments

@aboba aboba aboba approved these changes

@padenot padenot Awaiting requested review from padenot

@youennf youennf Awaiting requested review from youennf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coding Tool configuration
3 participants
@Djuffin @aboba @dalecurtis