Use 'InvalidStateError' for fully active check #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have a little bit of an over-reliance on NotAllowedError in the spec. |
|
Looks good. This is a breaking change, could you accompany it with a WPT so we don't forget to make the corresponding change in chromium? |
nsatragno
approved these changes
Jul 24, 2024
nsatragno
requested changes
Jul 24, 2024
index.bs
Outdated
| @@ -951,7 +951,7 @@ spec:css-syntax-3; | |||
| 1. Assert: |settings| is a [=secure context=]. | |||
|
|
|||
| 1. If |settings|'s [=relevant global object=]'s [=associated Document=] is not [=Document/fully active=], | |||
| then return [=a promise rejected with=] "{{NotAllowedError}}" {{DOMException}}. | |||
There was a problem hiding this comment.
Actually, we should also make the change for the other algorithms (request, store, prevent silent access, and create), no?
There was a problem hiding this comment.
oh yes, totally... will make those changes too.
marcoscaceres
commented
Jul 26, 2024
Absolutely! Will update the tests now. |
marcoscaceres
added a commit
to marcoscaceres/WebKit
that referenced
this pull request
Jul 26, 2024
https://bugs.webkit.org/show_bug.cgi?id=277125 rdar://132552299 Reviewed by NOBODY (OOPS!). Switched from NotAllowedError to InvalidStateError for non-fully active documents. Spec change: w3c/webappsec-credential-management#245 * LayoutTests/imported/w3c/web-platform-tests/credential-management/non-fully-active.https.html: * Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp: (WebCore::CredentialsContainer::preventSilentAccess const): (WebCore::CredentialsContainer::performCommonChecks):
github-actions bot
added a commit
that referenced
this pull request
Jul 26, 2024
SHA: 991c1ec Reason: push, by nsatragno Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Chromium bug: https://crbug.com/355603420 |
marcoscaceres
added a commit
to marcoscaceres/WebKit
that referenced
this pull request
Jul 29, 2024
https://bugs.webkit.org/show_bug.cgi?id=277125 rdar://132552299 Reviewed by NOBODY (OOPS!). Switched from NotAllowedError to InvalidStateError for non-fully active documents. Spec change: w3c/webappsec-credential-management#245 * LayoutTests/imported/w3c/web-platform-tests/credential-management/non-fully-active.https.html: * LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https.html: * Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp: (WebCore::CredentialsContainer::preventSilentAccess const): (WebCore::CredentialsContainer::performCommonChecks):
webkit-commit-queue
pushed a commit
to marcoscaceres/WebKit
that referenced
this pull request
Jul 30, 2024
https://bugs.webkit.org/show_bug.cgi?id=277125 rdar://132552299 Reviewed by Pascoe. Switched from NotAllowedError to InvalidStateError for non-fully active documents. Spec change: w3c/webappsec-credential-management#245 * LayoutTests/imported/w3c/web-platform-tests/credential-management/non-fully-active.https.html: * LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https.html: * Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp: (WebCore::CredentialsContainer::preventSilentAccess const): (WebCore::CredentialsContainer::performCommonChecks): Canonical link: https://commits.webkit.org/281535@main
davidtranhq
pushed a commit
to davidtranhq/WebKit
that referenced
this pull request
Jul 30, 2024
https://bugs.webkit.org/show_bug.cgi?id=277125 rdar://132552299 Reviewed by Pascoe. Switched from NotAllowedError to InvalidStateError for non-fully active documents. Spec change: w3c/webappsec-credential-management#245 * LayoutTests/imported/w3c/web-platform-tests/credential-management/non-fully-active.https.html: * LayoutTests/imported/w3c/web-platform-tests/digital-credentials/non-fully-active.https.html: * Source/WebCore/Modules/credentialmanagement/CredentialsContainer.cpp: (WebCore::CredentialsContainer::preventSilentAccess const): (WebCore::CredentialsContainer::performCommonChecks): Canonical link: https://commits.webkit.org/281535@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make errors more distinguishable, it would be good if we could use "InvalidStateError" instead for fully active checks.
The following tasks have been completed:
Implementation commitment:
Preview | Diff