Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presentation holder tests and cleanup #139

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Presentation holder tests and cleanup #139

merged 5 commits into from
Nov 13, 2024

Conversation

PatStLouis
Copy link
Collaborator

A few changes and improvements:

  • Added missing presentation holder tests.
  • Added self-asserted VC tests.
  • Fixed wrong related resource test (duplicate id).
  • Updated test numeration with dot values.
  • Split up some test statements into separate tests.

BigBlueHat
BigBlueHat requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So. The file numbering (411 vs. 4.11) was deliberate--as strange as it looks. The goal was to get the filesystem sorting to match the spec's sorting. I know it looks weird...but it does work. 😁

Happy to discuss/debate, though.

@PatStLouis
Copy link
Collaborator Author

Untitled
well, if it would have kept the ordering its showing in my vscode ide it would of been better, but it seems like github sorts differently, so I will have to agree with you on this one ;)

@PatStLouis
rename file numbering
f742b43 
Signed-off-by: PatStLouis <[email protected]>
@PatStLouis
Copy link
Collaborator Author

@BigBlueHat are you okay with the updated numbering?

@BigBlueHat
Copy link
Member

@BigBlueHat are you okay with the updated numbering?

Great work figuring that out! 😁

@BigBlueHat BigBlueHat merged commit 026e2bc into main Nov 13, 2024
2 checks passed
@BigBlueHat BigBlueHat deleted the presentation-holder-tests branch November 13, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigBlueHat BigBlueHat BigBlueHat approved these changes

@aljones15 aljones15 Awaiting requested review from aljones15

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatStLouis @BigBlueHat