-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readme section about the EnvelopingProof
tag usage.
#128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for documenting this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving, but do remember the issuer.id
becomes issuer in the actual VC which is relevant as an issuer should not being issuing a VC from another issuer.
@PatStLouis @decentralgabe any thoughts on what you'd expect to see set as |
I believe kid is the issuer: https://w3c.github.io/vc-jose-cose/#jwt-issuer it should be a did:key for the sake of simplicity and being in line with this test suite. |
the semantic layer and securing layer are distinct. the issuer property will still be present after you decode the vc jose cose payload. |
I would say for envelopes it would be a edit: I also want to suggest that for this specific test-suite, it doesn't really matter. As long as it matches the vcdm 2.0 spec of being a valid URI. It would matter more in something like a VC-JOSE test suite, which is another reason why I would like to keep this type of testing separate and focus on the data model here, not the semantics of the securing mechanism. |
I will also open a PR on the implementations repo to add the same information. |
There are no requirements for it to be a did:jwk, did:key, or any other DID method (or controller document URI) would work too. |
@decentralgabe all other test suites use |
thanks @aljones15 that makes sense. we can stick to did:jwk in our test suite to make things easier. |
This is to partially address the concerns raised in #127.
It's not a requirement to use data integrity to be conformant with this test suite. This test suite doesn't test the securing mechanism, only the data model.