Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make remote-playback-id globally unique. #193

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Make remote-playback-id globally unique. #193

merged 2 commits into from
Aug 27, 2019

Conversation

markafoltz
Copy link
Contributor

@markafoltz markafoltz commented Aug 24, 2019

This addresses Issue #147: Remote playback ID uniqueness

The action item [1] from the Berlin F2F is to require that remote-playback-ids are globally unique, with a view to a future API to allow reconnection to (or additional connections to) a remote playback in progress.

[1] https://www.w3.org/2019/05/24-webscreens-minutes.html#x10

See also:
Issue #149: Multiple controllers of remote playback
w3c/remote-playback#5: Reconnecting media elements to the playback


Preview | Diff

@markafoltz markafoltz requested a review from pthatcherg August 24, 2019 00:28
@markafoltz
Copy link
Contributor Author

PTAL @pthatcherg

@baylesj
Copy link
Contributor

baylesj commented Aug 26, 2019

LGTM, simple change that makes sense. Link to RFC 4122 is good.

@markafoltz markafoltz merged commit a139349 into gh-pages Aug 27, 2019
@markafoltz markafoltz deleted the remote-guid branch August 27, 2019 18:05
@markafoltz
Copy link
Contributor Author

Thanks @baylesj , merged. @pthatcherg, feel free to add comments afterwards.

Copy link
Contributor

@pthatcherg pthatcherg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants