Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MediaSessionActionHandler cb's type #330

Closed
wants to merge 1 commit into from
Closed

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented May 13, 2024

Fixes #322

Cc @saschanaz - how's this look?

Also, please see #331


Preview | Diff

@marcoscaceres marcoscaceres requested a review from youennf May 13, 2024 10:25
@saschanaz
Copy link
Member

I don't think we can have multiple dictionaries in a union. Consider this:

({ action: "play", seekOffset: 3, seekTime: 4, fastSeek: true, isActivating: true })

This would fit any of the dictionaries in the union. For this specific case we don't do ES-to-IDL conversion so maybe it's theoretically fine?

cc @domenic

@youennf
Copy link
Contributor

youennf commented May 31, 2024

@saschanaz, good point.
I guess this could work for IDL-to-ES conversion, but would probably need updating WebIDL processors, which UAs might not do.
I am tempted to revert the splitting of dictionaries in the spec. @steimelchrome, thoughts?

@steimelchrome
Copy link
Contributor

The fact that we can't just say MediaSessionActionDetails and allow 'subclass' dictionaries to be given feels like a strange limitation, but given that I'd agree with @youennf that reverting the dictionary split change makes the most sense

@youennf
Copy link
Contributor

youennf commented Sep 26, 2024

OK, let's close this PR, I'll work on a PR to revert the dictionary splitting.

@youennf youennf closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants