-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the possiblity to expose microphone/camera state via MediaStreamTrack muted state #313
Conversation
@jan-ivar, @steimelchrome, PTAL |
index.bs
Outdated
for=MediaSessionAction>togglemicrophone</a> or <a enum-value | ||
for=MediaSessionAction>togglecamera</a> <a>media session action</a>, user | ||
agent MUST first execute the corresponding {{MediaSessionActionHandler}}, | ||
and then, for each related <a>MediaStreamTrack</a>, [=queue a task=] to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
queuing at task generally needs a task source... do we have one we could use? (this is come up in other PRs too... would be good if we could figure out which one to use)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What we want to mandate here is the callback/event ordering, not the actual algorithm since the firing of the events is specified in mediacapture-main no task source defined yet though it should.
I am not sure how to best convey this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworded the sentence.
…treamTrack muted state. In that case, mention that action handlers are first called, then mute/unmute events fire in separate tasks.
368c8b0
to
80a4816
Compare
urlPrefix: https://www.w3.org/TR/mediacapture-streams/; spec: mediacapture-main | ||
type: dfn | ||
text: MediaStreamTrack muted state; url:#track-muted | ||
text: set MediaStreamTrack muted state; url:#set-track-muted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The [=muted=] concept is exported, but it's done wrongly in mediacapture-streams. Can we fix that? @jan-ivar maybe?
It should be something like <dfn class="export" for="MediaStreamTrack">muted state</dfn>
or something similar.
Same with set MediaStreamTrack muted state algorithm. We shouldn't need to be hard linking these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed w3c/mediacapture-main#985, I'll update the spec here when this gets fixed in media capture-main
Merging now, let's do improvements as follow-ups. |
In that case, mention that action handlers are first called, then mute/unmute events fire.
Preview | Diff