Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the possiblity to expose microphone/camera state via MediaStreamTrack muted state #313

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Jan 10, 2024

In that case, mention that action handlers are first called, then mute/unmute events fire.


Preview | Diff

@youennf
Copy link
Contributor Author

youennf commented Jan 10, 2024

@jan-ivar, @steimelchrome, PTAL

index.bs Outdated Show resolved Hide resolved
@youennf youennf requested a review from jan-ivar January 14, 2024 17:05
index.bs Outdated Show resolved Hide resolved
index.bs Outdated
for=MediaSessionAction>togglemicrophone</a> or <a enum-value
for=MediaSessionAction>togglecamera</a> <a>media session action</a>, user
agent MUST first execute the corresponding {{MediaSessionActionHandler}},
and then, for each related <a>MediaStreamTrack</a>, [=queue a task=] to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

queuing at task generally needs a task source... do we have one we could use? (this is come up in other PRs too... would be good if we could figure out which one to use)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we want to mandate here is the callback/event ordering, not the actual algorithm since the firing of the events is specified in mediacapture-main no task source defined yet though it should.
I am not sure how to best convey this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworded the sentence.

…treamTrack muted state.

In that case, mention that action handlers are first called, then mute/unmute events fire in separate tasks.
@youennf youennf force-pushed the expose-capture-state-as-muted-track branch from 368c8b0 to 80a4816 Compare January 15, 2024 14:42
Comment on lines +85 to +88
urlPrefix: https://www.w3.org/TR/mediacapture-streams/; spec: mediacapture-main
type: dfn
text: MediaStreamTrack muted state; url:#track-muted
text: set MediaStreamTrack muted state; url:#set-track-muted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The [=muted=] concept is exported, but it's done wrongly in mediacapture-streams. Can we fix that? @jan-ivar maybe?

It should be something like <dfn class="export" for="MediaStreamTrack">muted state</dfn> or something similar.

Same with set MediaStreamTrack muted state algorithm. We shouldn't need to be hard linking these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed w3c/mediacapture-main#985, I'll update the spec here when this gets fixed in media capture-main

@youennf
Copy link
Contributor Author

youennf commented Jan 22, 2024

Merging now, let's do improvements as follow-ups.

@youennf youennf merged commit 061778a into w3c:main Jan 22, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Jan 22, 2024
…treamTrack muted state. (#313)

SHA: 061778a
Reason: push, by youennf

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants