Update Constrainable Properties prose (follow-up to #948) #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-ivar
requested review from
alvestrand,
eehakkin,
youennf,
guidou and
eladalon1983
jan-ivar
commented
Apr 13, 2023
youennf
reviewed
Apr 13, 2023
getusermedia.html
Outdated
| @@ -1794,12 +1794,12 @@ <h2>Constrainable Properties</h2> | |||
| <td>{{double}}</td> | |||
| <td>The exact aspect ratio (width in pixels divided by height in | |||
| pixels, represented as a double rounded to the tenth decimal | |||
| place) or aspect ratio range.</td> | |||
There was a problem hiding this comment.
I filed #954 so that we can fix the description of aspect ratio range
youennf
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #948. Some of the prose mentioned range, and I forgot to update the audio processing boolean properties.
Preview | Diff