synchronously use same origin-domain in iframe check #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated WebKit: WebKit/WebKit#13389 I'll update the WPTests also to add a specific same origin-domain check. |
marcoscaceres
added a commit
to marcoscaceres/WebKit
that referenced
this pull request
Jun 2, 2023
… same origin-domain as top-origin https://bugs.webkit.org/show_bug.cgi?id=256241 rdar://107109904 Reviewed by NOBODY (OOPS!). Now does same origin-domain check against top-level origin. Relevant spec change: w3c/badging#107 * LayoutTests/imported/w3c/web-platform-tests/badging/setAppBadge_cross_origin.sub.https-expected.txt: * Source/WebCore/page/Navigator.cpp: (WebCore::Navigator::setAppBadge):
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106
Now checks "same origin-domain" instead of the more restrictive "same origin".
This change:
Implementation commitment (delete if not making normative changes):
Person merging, please make sure that commits are squashed with one of the following as a commit message prefix: