remove conditional division

vzhomeexperiments · Dec 6, 2020 · c695352 · c695352
1 parent 74a60b8
commit c695352
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -11,7 +11,6 @@
 ## Changes
 
 * solving warnings by changing example in *mt_make_model* function
-* conditional division of data by 100 in *mt_evaluate* function
 * change function *mt_make_model* to read manually checked dataset
 
 # lazytrade 0.4.2

diff --git a/R/aml_make_model.R b/R/aml_make_model.R
@@ -105,8 +105,8 @@ aml_make_model <- function(symbol, timeframe, path_model, path_data,
     model_status <- readr::read_csv(dec_file_path) %>% select(MaxPerf) %$% MaxPerf
   } else if(force_update == TRUE) {
     # delete the model and previous test results
-    remove(dec_file_path)
-    remove(m_path)
+    #try(remove(dec_file_path), silent = TRUE)
+    #try(remove(m_path),silent = TRUE)
     model_status <- -1
   } else { model_status <- 0 }
 

diff --git a/R/mt_evaluate.R b/R/mt_evaluate.R
@@ -79,11 +79,6 @@ mt_evaluate <- function(x, path_model, num_cols, timeframe){
   # load models
   m1 <- h2o::h2o.loadModel(m_path)
 
-  #normalize macd value if we are dealing with JPY pairs
-  if(stringr::str_detect(names(x), 'JPY')){
-    x <- x/100
-  }
-
     # Convert to matrix
     X_m <- lazytrade::to_m(x, num_cols) %>% as.data.frame()
     colnames(X_m) <- c(paste("X",1:num_cols,sep=""))