fix[ci]: fix README encoding in setup.py
#4348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cooper
force-pushed
the
ci/test-windows-build
branch
from
52ec4dd
to
4d41cb6
Compare
charles-cooper
changed the title
setup.py
harkal
approved these changes
Nov 5, 2024
fubuloubu
approved these changes
Nov 5, 2024
|
potentially related: #4297 |
sandbubbles
pushed a commit
to sandbubbles/vyper
that referenced
this pull request
Nov 7, 2024
the call to `setup()` would fail on windows when there are unicode characters in `README.md`, because files are apparently opened with encoding `cp1252` by default on windows. this commit ensures the file is opened with `utf-8` encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
testing CI
How I did it
fixes a blocker in #4342
How to verify it
Commit message
Description for the changelog
Cute Animal Picture