Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[venom]: add load elimination #4265

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Sep 29, 2024

What I did

add primitive sload/tload/mload elimination

How I did it

very primitive, keeps latest mload or mstore in a one-element "lattice", and weakens the sload/mload/tload to a store instruction if there is a hit on the same key.

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 12.28070% with 50 lines in your changes missing coverage. Please review.

Project coverage is 51.22%. Comparing base (b3ea663) to head (6923199).

Files with missing lines Patch % Lines
vyper/venom/passes/load_elimination.py 10.90% 49 Missing ⚠️
vyper/venom/__init__.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b3ea663) and HEAD (6923199). Click for more details.

HEAD has 125 uploads less than BASE
Flag BASE (b3ea663) HEAD (6923199)
138 13
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4265       +/-   ##
===========================================
- Coverage   91.40%   51.22%   -40.18%     
===========================================
  Files         112      113        +1     
  Lines       15927    15984       +57     
  Branches     2694     2711       +17     
===========================================
- Hits        14558     8188     -6370     
- Misses        935     7166     +6231     
- Partials      434      630      +196     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper marked this pull request as ready for review November 23, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants