Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[ci]: enable cancun testing #3861

Merged
merged 9 commits into from
Mar 19, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Mar 15, 2024

What I did

How I did it

How to verify it

Commit message

enable cancun testing. mostly, update to the version of py-evm and
eth-tester which enable cancun. adjust a couple tests which need to
behave separately depending on cancun vs pre-cancun.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.30%. Comparing base (58ecff5) to head (f184f18).

❗ Current head f184f18 differs from pull request most recent head 392280a. Consider uploading reports for the commit 392280a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3861      +/-   ##
==========================================
+ Coverage   86.21%   86.30%   +0.09%     
==========================================
  Files          92       92              
  Lines       14010    14010              
  Branches     3077     3077              
==========================================
+ Hits        12079    12092      +13     
+ Misses       1496     1488       -8     
+ Partials      435      430       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper
Copy link
Member Author

note: looks like there are some issues being caused in eth-tester by the new py-evm. waiting on eth-tester/py-evm maintainers to push a fix

@charles-cooper
Copy link
Member Author

with ethereum/py-evm#2159 and ethereum/eth-tester#284, this PR passes all codegen tests. (there are some storage layout tests which test against hardcoded layouts; i'll switch those in a bit)

@charles-cooper charles-cooper marked this pull request as ready for review March 19, 2024 13:15
@charles-cooper charles-cooper changed the title enable cancun testing feat[ci]: enable cancun testing Mar 19, 2024
@charles-cooper
Copy link
Member Author

i extracted the fuzz failure into this issue: #3875

@charles-cooper charles-cooper merged commit e589278 into vyperlang:master Mar 19, 2024
146 of 147 checks passed
@charles-cooper charles-cooper deleted the chore/test-cancun branch March 19, 2024 20:19
electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
enable cancun testing. mostly, update to the version of py-evm and
eth-tester which enable cancun. adjust a couple tests which need to
behave separately depending on cancun vs pre-cancun.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants