Skip to content
This repository has been archived by the owner on Dec 2, 2019. It is now read-only.

adds nk_tooltip_text #890

Closed
wants to merge 1 commit into from
Closed

adds nk_tooltip_text #890

wants to merge 1 commit into from

Conversation

Hejsil
Copy link
Contributor

@Hejsil Hejsil commented Aug 20, 2019

For when you have a string that is not \0 terminated

@dumblob
Copy link
Contributor

dumblob commented Aug 21, 2019

Hi, thanks for the proposal. To make this change happen, it would be wise to change (not add new API calls) the whole library to not use any null-terminated strings. For this reason I'm currently a bit reluctant to approve this PR. Would you be willing to make such an important step to happen?

@Hejsil
Copy link
Contributor Author

Hejsil commented Aug 21, 2019

Hmm, idk if I'd want to put the time in make such a change. Though, I do mostly work with none null-terminated strings so I might end up needing to do this.

Would this involve removing APIs like nk_label and only having nk_text?

@dumblob
Copy link
Contributor

dumblob commented Aug 22, 2019

Would this involve removing APIs like nk_label and only having nk_text?

In this case yes as the only motivation to have nk_label was to support null-terminated strings 😉 (back when Nuklear wasn't versioned and also when it became freshly versioned, it was needed to maintain backwards compatibility, but nowadays it's not such a big issue due to strict versioning).

@Hejsil
Copy link
Contributor Author

Hejsil commented Sep 18, 2019

Closing this in favor of having this as an issue (#905)

@Hejsil Hejsil closed this Sep 18, 2019
@Hejsil Hejsil deleted the add-tooltip-text branch September 18, 2019 17:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants