GitHub support #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored logic such that Package becomes more dynamic in that it is now more like a framework for package handlers. Was able to move the majority of old code into an abstract class that is then inherited by PyPIPackage and GitHubPackage with the individual implementation specifics.
Moved a few items around and added unittesting.
Allow autoupgrade to be used without the github module being installed.
Included important information about PyGithub being required for Github features to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created an abstract Package class (ABCPackage) that contains most of the old Package functionality. The remaining old functionality of Package was placed in the subclass PyPIPackage.
This allowed for the creation of a GitHubPackage that mirrors PyPIPackage in functionality except instead of using PyPI as the source, GitHub is used.
From there both PyPIPackage and GitHubPackage are bundled together into the new Package class. This new Package class returns the applicable package class (PyPI vs GitHub) depending on the arguments passed (or by accessing the class methods).