Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: remove tslib requirement #38

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Patch: remove tslib requirement #38

merged 1 commit into from
Nov 12, 2021

Conversation

kyle-johnson
Copy link
Contributor

@kyle-johnson kyle-johnson commented Sep 18, 2021

Closes #19, closes #31, closes #32

Tests pass. The only output difference is in dist/index.js which no longer includes:

var tslib_1 = require("tslib");

But instead simply inlines the single method:

var __exportStar = (this && this.__exportStar) || function(m, exports) {
    for (var p in m) if (p !== "default" && !Object.prototype.hasOwnProperty.call(exports, p)) __createBinding(exports, m, p);
};

Copy link

@denneh denneh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need this fix! LGTM :)

gabrielgrover added a commit to gabrielgrover/ts-results that referenced this pull request Sep 27, 2021
@Sysix
Copy link

Sysix commented Oct 20, 2021

@vultix please look into this PR, some people need this fix asap

@vultix vultix merged commit 614dc7c into vultix:master Nov 12, 2021
@vultix
Copy link
Owner

vultix commented Nov 12, 2021

Thank you for this!

@LouisWT
Copy link

LouisWT commented Dec 16, 2021

Release a new Version? We need this patch @vultix

@kevinsimper
Copy link
Contributor

@vultix It would be pretty cool to use ts-results in a type: "module" project 😄

@lawRathod
Copy link

@vultix would it be possible to make a new release post this patch is applied?

@drob
Copy link

drob commented Jan 4, 2023

Running into this as well, could we get a new release?

@Aaronius
Copy link

Aaronius commented Feb 3, 2023

Same here. Please release!

@rene-mueller
Copy link

@vultix please make a release

@eolculnamo2
Copy link

Any chance this update will be released soon? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet