This repository has been archived by the owner on May 28, 2023. It is now read-only.
Bugfix: Image file cache throws unhandled error if image not exists #580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only occurs when
config.imegable.caching.active === true
.If a product image does not exists on the platform/backend the local image action will return empty.
The image file cache will still try to cache the result but fail, throwing an exception that will not be handled
This PR will add and
error
state to theimageAction
and only cache the image if there is no error raised, thus preventing the unhandled error. I thought it would be better to not even try to cache if we know the is nothing to cache instead of just adding try/catch around thecache.save()
statement.I also created a specific edge case to forward the 404 not found status when the image is missing. I also changed the general image error status code from 400 to 500, because I thought it was more appropriate since it indicates an error with the server response and not an issue with the request.