Skip to content
This repository has been archived by the owner on May 28, 2023. It is now read-only.

Bugfix: Image file cache throws unhandled error if image not exists #580

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

didkan
Copy link
Contributor

@didkan didkan commented Sep 21, 2021

This only occurs when config.imegable.caching.active === true.

If a product image does not exists on the platform/backend the local image action will return empty.
The image file cache will still try to cache the result but fail, throwing an exception that will not be handled

This PR will add and error state to the imageAction and only cache the image if there is no error raised, thus preventing the unhandled error. I thought it would be better to not even try to cache if we know the is nothing to cache instead of just adding try/catch around the cache.save() statement.

I also created a specific edge case to forward the 404 not found status when the image is missing. I also changed the general image error status code from 400 to 500, because I thought it was more appropriate since it indicates an error with the server response and not an issue with the request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant