fix: do not wrap registering event listeners under effect

[ydcjeff]

Before:

  _effect(() => {
    _on(n7, "click", _ctx.inc);
  });
  _effect(() => {
    _on(n8, "click", _ctx.dec);
  });

After:

  _on(n7, "click", _ctx.inc);
  _on(n8, "click", _ctx.dec);

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	87.9 kB	33.4 kB	30.2 kB
runtime-vapor.global.prod.js	15.6 kB	5.81 kB	5.32 kB
vue-vapor.global.prod.js	47.4 kB (-3 B)	15.8 kB (+5 B)	14.3 kB (+4 B)
vue.global.prod.js	144 kB	52.4 kB	46.9 kB

Usages

Name	Size	Gzip	Brotli
createApp	48.6 kB	19 kB	17.4 kB
createSSRApp	51.8 kB	20.3 kB	18.6 kB
defineCustomElement	50.9 kB	19.8 kB	18.1 kB
vapor	15.5 kB	5.81 kB	5.33 kB
overall	61.9 kB	23.9 kB	21.8 kB

[sxzz]

event handler could be changed, so effect is necessary.

[ydcjeff]

@sxzz Do you mean reactive event handler?

[sxzz]

@ydcjeff Yes

[ydcjeff]

Interesting! I didn't happen to see in the Vue docs tho.

[ydcjeff]

I tried reactive event handler in the Vue SFC playground, and found that Vue wraps that handler with inline function.

    onClick: _cache[0] || (_cache[0] = (...args) => (handler.value && handler.value(...args)))

So I still think we do not need wrap under effect.

[autofix-troubleshooter]

Hi! I'm the autofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃