chore: futher optimize

vuejs · Nov 22, 2024 · 26cfbb1 · 26cfbb1
1 parent 217748e
commit 26cfbb1
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/packages/compiler-vapor/src/generators/prop.ts b/packages/compiler-vapor/src/generators/prop.ts
@@ -22,6 +22,7 @@ import {
   genMulti,
 } from './utils'
 import {
+  attributeCache,
   isHTMLGlobalAttr,
   isHTMLTag,
   isMathMLGlobalAttr,
@@ -44,6 +45,8 @@ export function genSetProp(
   } = oper
 
   const keyName = key.content
+  const tagName = tag.toUpperCase()
+  const attrCacheKey = `${tagName}_${keyName}`
 
   let helperName: VaporHelper
   let omitKey = false
@@ -55,7 +58,10 @@ export function genSetProp(
     omitKey = true
   } else if (modifier) {
     helperName = modifier === '.' ? 'setDOMProp' : 'setAttr'
-  } else if (shouldSetAsAttr(tag.toUpperCase(), keyName)) {
+  } else if (
+    attributeCache[attrCacheKey] ||
+    (attributeCache[attrCacheKey] = shouldSetAsAttr(tag.toUpperCase(), keyName))
+  ) {
     helperName = 'setAttr'
   } else if (
     (isHTMLTag(tag) && isHTMLGlobalAttr(keyName)) ||

diff --git a/packages/runtime-vapor/src/dom/prop.ts b/packages/runtime-vapor/src/dom/prop.ts
@@ -1,4 +1,5 @@
 import {
+  attributeCache,
   includeBooleanAttr,
   isArray,
   isFunction,
@@ -243,7 +244,11 @@ function shouldSetAsProp(
     return false
   }
 
-  if (shouldSetAsAttr(el.tagName, key)) {
+  const attrCacheKey = `${el.tagName}_${key}`
+  if (
+    attributeCache[attrCacheKey] ||
+    (attributeCache[attrCacheKey] = shouldSetAsAttr(el.tagName, key))
+  ) {
     return false
   }
 

diff --git a/packages/shared/src/domAttrConfig.ts b/packages/shared/src/domAttrConfig.ts
@@ -180,6 +180,11 @@ export function isRenderableAttrValue(value: unknown): boolean {
   return type === 'string' || type === 'number' || type === 'boolean'
 }
 
+/**
+ * cache seen attributes which must be set as attribute
+ */
+export const attributeCache: Record<string, boolean> = Object.create(null)
+
 /*
  * The following attributes must be set as attribute
  */