Download images for Help Center folder architecture #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PedroAntunesCosta
requested changes
Sep 16, 2024
There was a problem hiding this comment.
I have commented on minor issues, but I would also like to point out that I think we should be mindful of the URLs assembled in the else if and else conditions.
- In what situations will they be triggered? It is not clear to me.
- Given they are triggered, are those the URLs we want to be returned? It seems to me they are not.
PedroAntunesCosta
requested changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 83
1º Download the file from the original folder (Contentful) to the folder of each article.
2º Update the image reference link inside each article.