Upgrade angular2 to beta-2 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -56,12 +53,15 @@ | |||
| "markdown-loader": "0.1.7", | |||
| "marked": "0.3.5", | |||
| "moment": "2.10.6", | |||
| "ntypescript": "1.201602032217.1", | |||
There was a problem hiding this comment.
actually, looks opposite - you used tsc in prepublish which is said to be deprecated (in here https://github.com/basarat/tsc) and linked to ntypescript as a suggestion to move onto.
|
except 2 comments looks good, |
|
A quick note about beta3 - it happened to me too and couldn't get it through in time: angular/angular#6887 |
| this.options.selectivity.doEvent('selected', value); | ||
| // turn back focus to input from options | ||
| this.options.selectivity.element.nativeElement.children[1].children[0].focus(); | ||
| // TODO this crashed because of 'children' undefined: | ||
| // this.options.selectivity.element.nativeElement.children[1].children[0].focus(); |
There was a problem hiding this comment.
@valorkin please take a look at this commented line. I just commented it out because I didn't have much time to figure out what it really does. But there's some undefined element in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.