Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Add image endpoints #408

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jellejurre
Copy link
Contributor

@jellejurre jellejurre commented Nov 11, 2024

Note: Currently a draft because it can only be merged once all generators are confirmed to work with it.
My current edits to the generators assume files are .png.

Generators:

@Rexios80
Copy link
Collaborator

This generates fine in dart: vrchatapi/vrchatapi-dart#26

@jellejurre
Copy link
Contributor Author

This generates fine in dart: vrchatapi/vrchatapi-dart#26

It generates fine in all I've tested so far, but the multipart file type is either not supported at all or the mimetype is set wrong for it, so we'd have to test that either way

C0D3-M4513R added a commit to vrchatapi/vrchatapi-rust that referenced this pull request Nov 12, 2024
jellejurre added a commit to vrchatapi/vrchatapi-rust that referenced this pull request Nov 12, 2024
* Add multipart content type

* Regenerate with vrchatapi/specification#408

Signed-off-by: C0D3 M4513R <[email protected]>

* Use async file io and don't `unwrap`

* Don't use file-io for multipart uploads/image endpoints

---------

Signed-off-by: C0D3 M4513R <[email protected]>
Co-authored-by: C0D3 M4513R <[email protected]>
@jellejurre
Copy link
Contributor Author

fixes: #254 #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants