Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove regex patterns #259

Closed
wants to merge 3 commits into from
Closed

Remove regex patterns #259

wants to merge 3 commits into from

Conversation

JU5TDIE
Copy link
Contributor

@JU5TDIE JU5TDIE commented Sep 25, 2023

No description provided.

@Rexios80
Copy link
Collaborator

Can we just remove these instead?

@JU5TDIE
Copy link
Contributor Author

JU5TDIE commented Sep 25, 2023

Do you mean all regex patterns? Or only these two?

@Rexios80
Copy link
Collaborator

I would like to remove any and all data validation from the spec if the other contributors are okay with it. The way I see it, it can only ever cause issues and not really benefit anything. I think @Foorack and I discussed this before and they wanted to keep it so we know when things are outside of expected parameters, but then we just end up with broken libraries in production code and we have to fix them.

@JU5TDIE
Copy link
Contributor Author

JU5TDIE commented Oct 29, 2023

I synced commits into the wrong branch but I cannot revert that commit at the moment.

@Foorack
Copy link
Member

Foorack commented Oct 29, 2023

@Rexios80

but then we just end up with broken libraries in production

That is a very good argument. I still wish they could stay, but with the instability of VRC API it is not an option. I am in favour of removing them.

@JU5TDIE JU5TDIE changed the title Update InstanceID, WorldID regex Remove regex patterns Oct 31, 2023
@ariesclark
Copy link
Member

Superseded by #264.

@ariesclark ariesclark closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants