Fixed MaterialBuilder's conversion to glTF not copying the IOR value. #73
Annotations
10 warnings
Build:
build/SharpGLTF.CodeGen/SchemaReflection/SchemaTypesContext.cs#L66
Method UseBlittable passes parameter name 't' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
|
Build:
build/SharpGLTF.CodeGen/SchemaDownload.cs#L20
Method 'void SchemaDownload.Syncronize(string remoteUrl, string localDirectory)' passes a literal string as parameter 'value' of a call to 'void Console.WriteLine(string? value)'. Retrieve the following string(s) from a resource table instead: "... Clone Completed". (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1303)
|
Build:
tests/SharpGLTF.DownloadTestFiles/DownloadUtils.cs#L57
'WebClient.WebClient()' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
|
Build:
tests/SharpGLTF.DownloadTestFiles/DownloadUtils.cs#L15
Method SyncronizeGitRepository passes parameter name 'localDirectoryPath' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
|
Build:
tests/SharpGLTF.DownloadTestFiles/DownloadUtils.cs#L46
Method DownloadFile passes parameter name 'localFilePath' as the message argument to a ArgumentException constructor. Replace this argument with a descriptive message and pass the parameter name in the correct position. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2208)
|
Build:
tests/SharpGLTF.DownloadTestFiles/ExampleFiles.cs#L70
Unused field '_BabylonJsInvalidFiles' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1823)
|
Build:
src/SharpGLTF.Core/IO/JsonSerializable.cs#L416
'reader.TokenType == JSONTOKEN.StartObject' is always 'false'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
|
Build:
src/SharpGLTF.Core/Memory/MemoryImage.cs#L273
Modify 'get_IsValid' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
Build:
src/SharpGLTF.Core/Memory/MemoryImage.cs#L470
Modify '_IsKtx2Image' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
Build:
src/SharpGLTF.Core/Validation/ValidationContext.Guards.cs#L138
Change the type of parameter 'gltfURI' of method 'ValidationContext.IsValidURI(ValueLocation, string, params string[])' from 'string' to 'System.Uri', or provide an overload to 'ValidationContext.IsValidURI(ValueLocation, string, params string[])' that allows 'gltfURI' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
Loading