migrate away from erb #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jan 17, 2025
| # @summary Remove blank lines from a string | ||
| # @param content The content to remove blank lines from | ||
| # @return The content with blank lines removed | ||
| function unbound::clean_blank_lines ( |
There was a problem hiding this comment.
I think this is generic enough that it could also be part of extlib?
bastelfreak
reviewed
Jan 17, 2025
| $config_file = $unbound::config_file, | ||
| Array[Unbound::Resource_record_type] $local_data = [], | ||
| String $template_name = 'unbound/local_zone.erb' | ||
| Unbound::Local_zone_type $type, |
There was a problem hiding this comment.
I prefer the older style, with just a single whitespace. That makes the diff easier to read and makes git reverts / cherry-picks easier. But there's no consent in our style guide yet.
bastelfreak
reviewed
Jan 17, 2025
| ) { | ||
| $records = $local_data.map |$record| { |
There was a problem hiding this comment.
there's a lot going on here. Can you please add some comments about what's happening?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the templating code to move away from erb and where possible use the print_config function
This PR is currently a WIP, couple of outstanding things
Also happy to split this up into separate PRs if needed