try and validate config inside every potentially breaking concat/file… #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft for now because I wanted to fire it up to see what the CI/CD made of the first draft version of the changes, I'll come back to it to try and finalise later. |
|
Ok, the CI tells me clearly that trying to validate each component config part individually (at the time it's deployed) isn't going to work, so we're going to have to try wrapping the service notify up in an exec to validate the config and avoid restarting rsyslog (and stopping logging) when the config is not valid. That's one for another day. Please feel free to correct me if I'm wrong! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… resource
Pull Request (PR) description
This Pull Request (PR) fixes the following issues