Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart rsyslog if feature_packages are installed #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bsper2
Copy link

@bsper2 bsper2 commented Apr 21, 2022

Pull Request (PR) description

Setup rsyslog so that if any $feature_packages are given rsyslog will
restart after those $feature_packages are installed.

Forcing a restart of rsyslog after installation of any $feature_packages
are installed is important if you have an rsyslog config that is not
valid without the additional package from $feature_packages in place.

Setup rsyslog so that if any $feature_packages are given rsyslog will
restart after those $feature_packages are installed.

Forcing a restart of rsyslog after installation of any $feature_packages
are installed is important if you have an rsyslog config that is not
valid without the additional package from $feature_packages in place.
@bsper2 bsper2 force-pushed the bsper2/push_upstream branch from e5e14af to df14a58 Compare April 21, 2022 23:16
@bsper2
Copy link
Author

bsper2 commented Apr 21, 2022

I'm pretty new to spec tests, but I think what I added related to my changes in the pull request are ok.

The last error being reported by CI is Unnecessary disabling of 'RSpec/EmptyExampleGroup', which doesn't look to be from my changes and I'm not sure I understand enough to offer a fix there.

@jhoblitt
Copy link
Member

Could you rebase on current master so gha will run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants