-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter user / group for ressource archive #454
base: master
Are you sure you want to change the base?
Conversation
rebased the commit |
rebased |
Is there any way to push for this PR? |
@ndelic0 I rebased it again.In case the acceptance tests fail again it would be nice if someone could investigate why they fail. |
these checks appear to be passing the failing tests are initial connection tests failing on the host running the test ? or are there other tests failing that I can't see ? I'm happy to work through the failures to get this merged and released as it's a good fix for a frustrating bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not extend the existing tests to cover this behaviour change?
Dear @dhoppe, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Fixes #448