-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Reload rather than restart nscd #56
base: master
Are you sure you want to change the base?
Conversation
5d704e4
to
eb624d1
Compare
Dear @traylenator, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
Dear @traylenator, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
Dear @traylenator, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
data/Ubuntu-16.04.yaml
Outdated
@@ -0,0 +1,2 @@ | |||
--- | |||
nscd::service_restart: /usr/sbin/service nscd reload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this valid? I never saw a 16.04 without systemd and in all other modules we assume 16.04 and newer ubuntus are running with systemd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/bin/systemctl
just to be annoying.
data/Debian-8.yaml
Outdated
@@ -0,0 +1,2 @@ | |||
--- | |||
nscd::service_restart: /usr/sbin/service nscd reload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that Debian 8 could be used with systemd and sysv, but in all other modules we have we assume it's running systemd. (also I think we should not support debian 8 anymore because it has very limited support and debian 9/10 are available)
Pull Request (PR) description
On configuration change nscd should be reloaded and not restarted
will be called as appropriate.